Array of strings on ShellCommand to allow paths with spaces

[javiermanzano]

No description provided.

[hiteshsondhi88]

can you please change this to 22

[hiteshsondhi88]

This PR will affect the current users, what do you think about creating polymorphic methods and leave the current users unaffected ?

[JovinPJ]

How can i get these changes? i have the same issue with spaces in filepath.
I am using Android Studio, and in 'dependencies' using,
compile 'com.github.hiteshsondhi88.libffmpeg:FFmpegAndroid:0.2.5'

[rafaelekol]

I also need this commit, can you advice how to import this changes to our project.

[JovinPJ]

Thanks hiteshsondhi88, worked for me :)

[ab-helly]

@JovinPJ how did you get these changes with gradle?

[JovinPJ]

@ab-helly
please check the link http://hiteshsondhi88.github.io/ffmpeg-android-java/
Actually, what i've done is downloaded the '.aar' and included in my lib folder
and added the dependency like
'compile(name:'FFmpegAndroid', ext:'aar')'.
'FFmpegAndroid' was name of my aar file
There is also option like ,
compile 'com.github.hiteshsondhi88.libffmpeg:FFmpegAndroid:0.2.5' for adding dependency

One drawback ,i noticed is that the apk size become very large(>22mb).

Thanks

[ab-helly]

@JovinPJ thanks, aar should work for me. 0.2.5 still doesn't contain these changes

[bramgiessen]

How can I use this commit?

[mattsff]

I downloaded aar file and it's not working yet, do you know how can I get it ? Only compiling the fork? Thanks!

[JovinPJ]

please let me know , what is your issue.

ffmpeg.execute(cmd, new ExecuteBinaryResponseHandler() {

}

here 'cmd' is a string array.

did you able to compile this?

Thanks

[mattsff]

I could do it donwloading all project and put it as module. I couldn't through gradle or AAR file.
It works now, thanks !

[kschick]

@JovinPJ How did you get this change from the aar? The aar linked to from that site is still version 0.2.5.

[silentsilas]

Yeah, the current .aar in this repository is using an old version. You'll have to pull down the repository and open it in Android Studio, then run the assembleRelease gradle script via the project root's gradle file.

If it runs successfully, you'll find the updated .aar at build/outputs/aar/FFmpegAndroid-release.aar

I personally had to undo the String[] changes in this commit and swapped out the FFmpeg binaries with the more recent ones from PR #70

[JovinPJ]

Hi ,
sorry for the delay, if you give me your mail id i'll send the aar file

[lekhanhduybkhn]

Hi JovinPJ there is my email [email protected]. Could you send me arr file. so I try download aar and gradle but file name with space is don't work for me

[symphonyrecords]

WhiteSpace in file path