Skip to content

Fix features typo in ArrayQueue's error types (crossbeam-queue) #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
May 3, 2020
Merged

Fix features typo in ArrayQueue's error types (crossbeam-queue) #485

2 commits merged into from
May 3, 2020

Conversation

@mexus
Copy link
Contributor

@mexus mexus commented Apr 6, 2020

Currenly, PushError and PopError do not implement std::error::Error even when std feature is activated :(

@jeehoonkang jeehoonkang mentioned this pull request Apr 10, 2020
Merged
@mexus
Fix features typo in ArrayQueue's error types
7abb69d 
Currenly, `PushError` and `PopError` do not implement `std::error::Error` even when `std` feature is activated :(
@mexus
Copy link
Contributor Author

mexus commented Apr 17, 2020

rebased 👌

@jeehoonkang
Copy link
Contributor

jeehoonkang commented Apr 18, 2020

It seems CI fails: https://github.com/crossbeam-rs/crossbeam/pull/485/checks?check_run_id=595070829

@taiki-e
Copy link
Member

taiki-e commented Apr 18, 2020

Probably it needs to add leading-colon to the path. (std::error::Error -> ::std::error::Error)

@mexus
Copy link
Contributor Author

mexus commented Apr 19, 2020

Yep, seems like it did the trick!

Sorry I haven't tested it locally at the first place :(

ghost
ghost approved these changes May 3, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit 485971e into crossbeam-rs:master May 3, 2020
exrook pushed a commit to exrook/crossbeam that referenced this pull request Oct 7, 2020
@chmanchester
Provide the failing process' stderr when failing to detect the compil…
1f8248c 
…er. Fixes crossbeam-rs#485
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mexus @jeehoonkang @taiki-e