Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: enhance error handling for localization folder creation in multi…
…ple classes
  • Loading branch information
serhii-londar committed Jan 28, 2026
commit 44b0f416785225f9c4bd7772d2c2b961c1085822
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ class LocalLocalizationStorage: LocalLocalizationStorageProtocol {
/// - Parameter localization: Current localization.
init(localization: String) {
self.localization = localization
self.localizationFolder = (try? CrowdinFolder.shared.createFolder(with: Strings.crowdin.rawValue)) ?? CrowdinFolder.shared
do {
self.localizationFolder = try CrowdinFolder.shared.createFolder(with: Strings.crowdin.rawValue)
} catch {
CrowdinLogsCollector.shared.add(log: CrowdinLog(type: .error, message: "Failed to create Crowdin localization folder '\(Strings.crowdin.rawValue)': \(error.localizedDescription)"))
self.localizationFolder = CrowdinFolder.shared
Comment thread
cursor[bot] marked this conversation as resolved.
}
}

/// Folder used for storing all localization files.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ import Foundation
class RULocalLocalizationStorage: LocalLocalizationStorage {
override init(localization: String) {
super.init(localization: localization)
if let folder = try? CrowdinFolder.shared.createFolder(with: "RealtimeUpdates") {
self.localizationFolder = folder
do {
self.localizationFolder = try CrowdinFolder.shared.createFolder(with: "RealtimeUpdates")
} catch {
CrowdinLogsCollector.shared.add(log: CrowdinLog(type: .error, message: "Failed to create RealtimeUpdates folder: \(error.localizedDescription). Falling back to root CrowdinFolder."))
self.localizationFolder = CrowdinFolder.shared
}
Comment thread
cursor[bot] marked this conversation as resolved.
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,17 @@
}

static let folder: FolderProtocol = {
(try? CrowdinFolder.shared.createFolder(with: Strings.XCStrings.rawValue)) ?? CrowdinFolder.shared
do {
return try CrowdinFolder.shared.createFolder(with: Strings.XCStrings.rawValue)
} catch {
CrowdinLogsCollector.shared.add(
log: CrowdinLog(
type: .error,
message: "XCStringsStorage: Failed to create '\(Strings.XCStrings.rawValue)' folder. Falling back to root CrowdinFolder. Error: \(error.localizedDescription)"
)
)
return CrowdinFolder.shared
}
}()

static func getFile(path: String) -> Data? {
Expand All @@ -170,7 +180,7 @@
}
}

class CrowdinXcstringsDownloadOperation: CrowdinDownloadOperation {

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (macOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (tvOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (watchOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (iOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (watchOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (macOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (tvOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Build Swift Package (iOS)

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Test

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance

Check warning on line 183 in Sources/CrowdinSDK/Providers/Crowdin/LocalizationDownloader/Operations/CrowdinXcstringsDownloadOperation.swift

View workflow job for this annotation

GitHub Actions / Test

class 'CrowdinXcstringsDownloadOperation' must restate inherited '@unchecked Sendable' conformance
var timestamp: TimeInterval?
let eTagStorage: AnyEtagStorage
var completion: CrowdinDownloadOperationCompletion? = nil
Expand Down
Loading