Skip to content

Add unit tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crusaderky wants to merge 4 commits into from
Closed

Add unit tests #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7aebf6
Add unit tests
crusaderky Dec 11, 2025
d0112c0
Test on Mac and Windows
crusaderky Dec 11, 2025
2474f41
Merge branch 'master' into tests
crusaderky Dec 12, 2025
b2ba9c8
Use a single TODO at the top of the file
crusaderky Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test on Mac and Windows
  • Loading branch information
@crusaderky
crusaderky committed Dec 11, 2025
commit d0112c04fb36610133cc0a252c8fbf473b0ec35f
20 changes: 16 additions & 4 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,30 @@ defaults:

jobs:
test:
name: Python ${{ matrix.python-version }} NumPy ${{ matrix.numpy-version}}
runs-on: ubuntu-latest
name: ${{ matrix.os }} Python ${{ matrix.python-version }} NumPy ${{ matrix.numpy-version}}
runs-on: ${{ matrix.os}}
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest]
python-version: ["3.11", "3.14"]
numpy-version: ["2.3.0", latest]
include:
- python-version: "3.8"
# Test oldest supported Python and NumPy versions
- os: ubuntu-latest
python-version: "3.8"
numpy-version: "1.18.0"
- python-version: "3.14"
# Test vs. NumPy nightly wheels
- os: ubuntu-latest
python-version: "3.14"
numpy-version: "nightly"
# Test issues re. preinstalled SSL certificates on different OSes
- os: windows-latest
python-version: "3.14"
numpy-version: latest
- os: macos-latest
python-version: "3.14"
numpy-version: latest

steps:
- name: Checkout
Expand Down
3 changes: 3 additions & 0 deletions ml_datasets/test/test_datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import platform

import pytest
import numpy as np

Expand Down Expand Up @@ -59,6 +61,7 @@ def test_reuters():
# TODO test output contents


@pytest.mark.xfail(platform.system() == "Windows", reason="path issues")
def test_snli():
train, dev = ml_datasets.snli()
# TODO test output contents
Expand Down