Skip to content

Inconsistency in token variable naming #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Inconsistency in token variable naming #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions program-analysis/echidna/property-creation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ In this example, users can deposit tokens using `depositShares`, mint shares usi
```solidity
contract Test {
DeFi c;
ERC20 t;
ERC20 token;

constructor() {
c = DeFi(..);
Expand Down Expand Up @@ -120,7 +120,7 @@ Avoiding reverts doesn't mean that the contract is in a valid state. Let's add s
function withdrawShares_never_reverts(uint256 val) public {
if (c.getShares(address(this)) >= val) {
try c.withdrawShares(val) { /* not reverted */ } catch { assert(false); }
assert(t.balanceOf(address(this)) > 0);
assert(token.balanceOf(address(this)) > 0);
}
}
...
Expand All @@ -143,7 +143,7 @@ In this generic example, it is unclear if there is a way to calculate how many s
uint256 shares = c.getShares(address(this);
assert(shares > 0);
try c.withdrawShares(shares) { /* not reverted */ } catch { assert(false); }
assert(t.balanceOf(address(this)) == original_balance);
assert(token.balanceOf(address(this)) == original_balance);
}
}
...
Expand Down