Skip to content

Conversation

ahpaleus
Copy link
Contributor

@ahpaleus ahpaleus commented Jan 26, 2023

This pull request adds the Check Markdown links to Github Actions. As the building-secure-contracts repo relies heavily on internal/external URLs, the proposed improvement will make this project more dependable.

@ahpaleus ahpaleus requested a review from elopez January 26, 2023 09:51
@ahpaleus ahpaleus requested a review from montyly as a code owner January 26, 2023 09:51
@montyly
Copy link
Contributor

montyly commented Jan 26, 2023

awesome idea @ahpaleus

@gustavo-grieco
Copy link
Contributor

This looks good but can we get this new test in green before merging?

@ahpaleus
Copy link
Contributor Author

ahpaleus commented Feb 1, 2023

This looks good but can we get this new test in green before merging?

Sure. For now, I have to put it on the back burner, I will come back to it next week.

@montyly montyly mentioned this pull request Feb 15, 2023
@montyly montyly merged commit b19a349 into crytic:master Feb 15, 2023
@Kingjames52-bot
Copy link

Looks good so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI improvement by catching invalid links

4 participants