add hasTrashedItems property to drive object #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
requested review from
diocas,
glpatcern,
jessegeens and
labkode
as code owners
micbar
approved these changes
Jul 3, 2025
Member
micbar
left a comment
micbar
left a comment
There was a problem hiding this comment.
Fine from my POV
@glpatcern This flag is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an aditional bool flag to the drive item called
hasTrashItemsthis is used to show whether there are items in the drives trashbin or not.With that little change, everybody will be able to implement a cost-efficient way to query whether a storage provider has trashed items, without having to read the whole trashbin. (our current implementation can be reviewed here for decomposedfs and posixfs: https://github.com/opencloud-eu/reva/pull/268/files)