Added support for federated groups + added comments #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glpatcern
requested review from
diocas,
jessegeens and
labkode
as code owners
glpatcern
force-pushed
the
group-types
branch
from
d839566 to
60e0ef1
Compare
jessegeens
reviewed
Sep 4, 2025
glpatcern
force-pushed
the
group-types
branch
from
60e0ef1 to
80c4e9b
Compare
jessegeens
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for future "federated" groups, in particular looking after OCM-based federations.
Also this prepares a change similar to #247, which would be a breaking change for uniformity, where group filters are called
query. @micbar I guess this specific PR is OK, and without further comments we will go ahead also for that.