Add permissions to StorageSpace definition #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegeens
requested review from
diocas,
glpatcern and
labkode
as code owners
jessegeens
force-pushed
the
feat/permissions-on-storage-space
branch
from
bdd4acf to
2ac8075
Compare
glpatcern
approved these changes
Sep 8, 2025
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
I think it's fine to keep this OPTIONAL, as with a bunch of other parameters that are not required for backwards compatibility. At some stage we have to review the "backwards compatibility" and decide the minimum set of parameters that make Spaces work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.