Add support for updating readme, thumbnail in spaces #5260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jessegeens
force-pushed
the
fix/spaces-image
branch
29 times, most recently
from
279a894 to
ef870bc
Compare
jessegeens
force-pushed
the
fix/spaces-image
branch
from
0c4fe38 to
df61dbe
Compare
Contributor
|
Related fix in front-end: cernbox/web/pull/206 |
diocas
reviewed
Aug 13, 2025
Contributor
diocas
left a comment
diocas
left a comment
There was a problem hiding this comment.
Just some quick initial comments. To be continued.... :)
jessegeens
force-pushed
the
fix/spaces-image
branch
7 times, most recently
from
f5c5d39 to
016fdfb
Compare
…pace signature into projects
jessegeens
force-pushed
the
fix/spaces-image
branch
from
016fdfb to
ebb9fef
Compare
diocas
requested changes
Aug 15, 2025
jessegeens
force-pushed
the
fix/spaces-image
branch
3 times, most recently
from
689e88f to
136cc4d
Compare
diocas
requested changes
Aug 19, 2025
jessegeens
force-pushed
the
fix/spaces-image
branch
2 times, most recently
from
9f96e8a to
bf980ab
Compare
* Also did some other small refactorings that were mentioned in the review of the PR * And added some comments
jessegeens
force-pushed
the
fix/spaces-image
branch
from
bf980ab to
a3f73b7
Compare
diocas
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
This required:
Additionally, the projects catalogue now directly implements the methods of the spaces registry.