Skip to content

Added requested changes by front with tests#100

Merged
joaquinfeltes merged 1 commit into
developfrom
hotfix/imperio_corrections
Nov 30, 2020
Merged

Added requested changes by front with tests#100
joaquinfeltes merged 1 commit into
developfrom
hotfix/imperio_corrections

Conversation

@csralvall

@csralvall csralvall commented Nov 30, 2020

Copy link
Copy Markdown
Owner

Things to review:

  • Nombres significativos de variables y funciones
  • Consistencia con el idioma usado (todo ingles)
  • Modularizacion (En clases o en metodos y funciones)
  • Cada funcion hace una sola cosa
  • identacion y estilo (PEP8)
  • niveles de bloques (2 ok , 3 razonable, 4 no)
  • Cada funcion no sobrepase las 20 lineas
  • Logica

@csralvall csralvall added the hotfix Some things were missed on the pull request label Nov 30, 2020
@csralvall csralvall self-assigned this Nov 30, 2020
@joaquinfeltes joaquinfeltes merged commit 376b674 into develop Nov 30, 2020
@joaquinfeltes joaquinfeltes deleted the hotfix/imperio_corrections branch November 30, 2020 21:14
guidoivetta added a commit that referenced this pull request Dec 2, 2020
* Best variable names (#71)

* Feature/sv 115 board types (#72)

* SV-127 #comment Match name is host name (#73)

* Feature/sv 106 borrar player (#75)

* SV-126 #comment Added Scrolling Bar (#74)

* Added Avada Kedavra title (#76)

* Feature/sv 110 expelliarmus (#77)

* Feature/sv 129 ganador (#78)

* Feature/sv 111 crucio (#79)

* Feature/sv 97 change password (#80)

* Feature/sv 108 creator leave match (#81)

* SV-99 #comment change email endpoint finished with tests (#82)

* Change Password and Email Front (#84)

* SV-128 #comment Added winner message (#86)

* SV-116 #comment Added boards (#85)

* SV-109 #comment Expelliarmus component added (#87)

* SV-100 #comment give profile data endpoint finished with tests, also fixed some previus endpoints (#83)

* Feature/sv 113 chat (#89)

* Feature/sv 107 leave game react (#91)

* SV-124 #comment Finished Component (#92)

* Crucio and Spell components added (#93)

* Feature/sv 114 chat front (#94)

* SV-114 #comment Started chat

* SV-128 #comment Added winner message (#86)

* SV-116 #comment Added boards (#85)

* SV-109 #comment Expelliarmus component added (#87)

* SV-100 #comment give profile data endpoint finished with tests, also fixed some previus endpoints (#83)

* Feature/sv 113 chat (#89)

* Feature/sv 107 leave game react (#91)

* SV-124 #comment Finished Component (#92)

* SV-114 #comment Started chat

* SV-114 #comment Finished Chat

* SV-114 #comment Fixed Bug

Co-authored-by: Manuel Sosa <54127298+ManuelSosaMartinez@users.noreply.github.com>
Co-authored-by: rortiz04 <50550642+rortiz04@users.noreply.github.com>
Co-authored-by: joaquinfeltes <51490191+joaquinfeltes@users.noreply.github.com>

* Feature/sv 103 list history (#96)

* Feature/sv 118 imperio (#95)

* SV-102 #message Finished Profile Info (#98)

* SV-119 #comment Imperio Component (#97)

* Added requested changes by front with tests (#100)

* SV-104 #comment Added Component and fixed bug in backend (#101)

* Changed Error Message Chat Front  (#102)

* Everybody Can See History  (#103)

* Hotfix/refactoring crud #done (#104)

Co-authored-by: Manuel Sosa <54127298+ManuelSosaMartinez@users.noreply.github.com>
Co-authored-by: Matidp <61301073+Matidp@users.noreply.github.com>
Co-authored-by: Guido Ivetta <guidoivetta@gmail.com>
Co-authored-by: csralvall <46329881+csralvall@users.noreply.github.com>
Co-authored-by: rortiz04 <50550642+rortiz04@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix Some things were missed on the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants