Skip to content

small updates #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5saviahv merged 6 commits into from
Jun 24, 2024
+213 −199
Merged

small updates #513

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b63788e
test asset seems to be faulty
5saviahv Jun 24, 2024
0666e31
more JSDoc like comments
5saviahv Jun 24, 2024
d954ff5
update helpers
5saviahv Jun 24, 2024
a2a87a7
added helper function
5saviahv Jun 24, 2024
3c7f4a9
allow "./" in get entry
5saviahv Jun 24, 2024
1eecf55
test for zipnamefix
5saviahv Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test for zipnamefix
  • Loading branch information
@5saviahv
5saviahv committed Jun 24, 2024
commit 1eecf552d900b4912d94fffe7c3196c1e794caf9
29 changes: 27 additions & 2 deletions test/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use strict";
const { expect } = require("chai");
const { crc32, canonical, sanitize } = require("../util/utils");
const { crc32, canonical, sanitize, zipnamefix } = require("../util/utils");
const pth = require("path");

describe("utils", () => {
Expand Down Expand Up @@ -70,6 +70,31 @@ describe("utils", () => {
});

it("function canonical()", () => {
const tests = [
// no name
{ file: "", result: "" },
// file has name
{ file: "file", result: "file" },
{ file: "../file", result: "file" },
{ file: "../../../file", result: "file" },
{ file: "./../file", result: "file" },
{ file: "../../file", result: "file" },
{ file: "../../file1/../file2", result: "file2" },
{ file: "../subfolder/file2", result: pth.normalize("subfolder/file2") },
{ file: "../subfolder2/file2", result: pth.normalize("subfolder2/file2") },
{ file: "../subfolder/file2", result: pth.normalize("subfolder/file2") },
{ file: "../../subfolder2/file2", result: pth.normalize("subfolder2/file2") }
];

for (const { file, result } of Array.from(tests)) {
tests.push({ result, file: file.split("/").join("\\") });
}

for (let test of tests) {
expect(canonical(test.file)).to.equal(test.result);
}
});
it("function zipnamefix()", () => {
const tests = [
// no name
{ file: "", result: "" },
Expand All @@ -91,7 +116,7 @@ describe("utils", () => {
}

for (let test of tests) {
expect(canonical(test.file)).to.equal(test.result);
expect(zipnamefix(test.file)).to.equal(test.result);
}
});
});
Expand Down