Skip to content

Cucumber now creates whatever directories are necessary to make a report #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidjgoss merged 8 commits into from
Mar 23, 2023
Merged

Cucumber now creates whatever directories are necessary to make a report #2266

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5af7258
Cucumber now creates whatever directories are necessary to make a report
Mar 22, 2023
c569362
Updated changelog and docs
Mar 22, 2023
cf5d171
Changes requested by David Goss
Mar 22, 2023
26212c4
Move formatter creation to try block so the formatter is not created …
Mar 22, 2023
049f986
Halt fully, don't just log a warning and continue. This is closer to …
Mar 22, 2023
b8c39c2
Remember Prettier... Now don't rush
Mar 22, 2023
b805dcd
Rollback as requested.
Mar 22, 2023
8a0a36c
Update CHANGELOG.md
davidjgoss Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move formatter creation to try block so the formatter is not created … 
…if it can't write output.
  • Loading branch information
Michael Morris committed Mar 22, 2023
commit 26212c4c57841d65cf5359ce06e6e63538c8cdf7
15 changes: 9 additions & 6 deletions src/api/formatters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,17 @@ export async function initializeFormatters({

try {
await mkdirp(path.dirname(absoluteTarget))

const stream: IFormatterStream = fs.createWriteStream(null, {
fd: await fs.open(absoluteTarget, 'w'),
})

formatters.push(await initializeFormatter(stream, target, type))
} catch (error) {
logger.warn('Failed to ensure directory for formatter target exists')
logger.warn(
`Cucumber was unable to create file "${absoluteTarget}". Check the access permissions of the directory. The test will continue from here, but no report file will be generated.`
)
}

const stream: IFormatterStream = fs.createWriteStream(null, {
fd: await fs.open(absoluteTarget, 'w'),
})
formatters.push(await initializeFormatter(stream, target, type))
})(target, type)
)
})
Expand Down