Skip to content

Nested steps should query over the wire too #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Nested steps should query over the wire too #45

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
37a3e6c
See if nested steps query over the wire
mattwynne Jul 16, 2021
d9a60c7
Merge remote-tracking branch 'origin/main' into 1-see-if-nested-steps…
aurelien-reeves Jan 7, 2022
14593cd
Fix nested step feature
aurelien-reeves Jan 7, 2022
b2a9587
Revert "Fix nested step feature"
mattwynne Jul 12, 2022
3ec0c9e
Clarify example for calling a nested step over the wire
mattwynne Jul 13, 2022
d6f4fab
Merge branch 'main' into 1-see-if-nested-steps-query-wire-server
mattwynne Jul 13, 2022
c241b30
Fix indentation
mattwynne Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix indentation
  • Loading branch information
@mattwynne
mattwynne committed Jul 13, 2022
commit c241b30506fc0cce4a0009491090c2c92ea32541
23 changes: 11 additions & 12 deletions features/call_nested_wire_step.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
Feature: Call nested wire step

If the user specifies a "nested" step in their Ruby step definitions, the
search for that step definition should include steps defined over the wire.

Expand All @@ -12,14 +11,14 @@ Feature: Call nested wire step
"""
host: localhost
port: 54321

"""
And a file named "features/nested_step.feature" with:
"""
Feature: Nested
Scenario: Nested
Given a step over the wire
Given a ruby step
Given a step over the wire
And a ruby step
"""
And a file named "features/step_definitions/steps.rb" with:
"""
Expand All @@ -28,18 +27,18 @@ Feature: Call nested wire step
end
"""
And there is a wire server running on port 54321 which understands the following protocol:
| request | response |
| ["step_matches",{"name_to_match":"a ruby step"}] | ["success",[]] |
| ["step_matches",{"name_to_match":"a step over the wire"}] | ["success",[{"id":"1", "args":[]}]] |
| ["begin_scenario"] | ["success"] |
| ["invoke",{"id":"1","args":[]}] | ["success"] |
| ["end_scenario"] | ["success"] |
| request | response |
| ["step_matches",{"name_to_match":"a ruby step"}] | ["success",[]] |
| ["step_matches",{"name_to_match":"a step over the wire"}] | ["success",[{"id":"1", "args":[]}]] |
| ["begin_scenario"] | ["success"] |
| ["invoke",{"id":"1","args":[]}] | ["success"] |
| ["end_scenario"] | ["success"] |
When I run `cucumber -f progress`
And it should pass with:
"""
.

1 scenario (1 passed)
1 step (1 passed)

"""