Update page-lifecycle and y-indexeddb with tarball links #3262
+71
−17
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,3 @@ updates: | |
| schedule: | ||
| interval: 'weekly' | ||
| open-pull-requests-limit: 10 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,6 +61,7 @@ | |
| "workspace:" | ||
| ], | ||
| "allowed-hosts": [ | ||
| "codeload.github.com", | ||
| "github.com", | ||
| "npm", | ||
| "yarn" | ||
|
|
@@ -71,7 +72,9 @@ | |
| "resetMocks": false | ||
| }, | ||
| "resolutions": { | ||
| "@pandacss/node@npm:0.47.0": "patch:@pandacss/node@npm%3A0.47.0#~/.yarn/patches/@pandacss-node-npm-0.47.0.patch", | ||
| "page-lifecycle": "https://codeload.github.com/magic-akari/page-lifecycle/tar.gz/50b50421bdeab3d211a57e81a277f699638373b0", | ||
| "y-indexeddb": "https://codeload.github.com/raineorshine/y-indexeddb/tar.gz/60b960009085b1a988b5064ee35703229231531f" | ||
| }, | ||
| "workspaces": [ | ||
| "packages/*" | ||
|
|
@@ -110,7 +113,7 @@ | |
| "murmurhash3js": "^3.0.1", | ||
| "nanoid": "^5.1.5", | ||
| "openai": "^5.20.3", | ||
| "page-lifecycle": "^0.1.2", | ||
| "pluralize": "^8.0.0", | ||
| "qrcode.react": "^4.2.0", | ||
| "rc-slider": "^11.1.9", | ||
|
|
@@ -144,7 +147,7 @@ | |
| "workbox-strategies": "^7.3.0", | ||
| "workbox-window": "^7.3.0", | ||
| "xhtml-purifier": "^0.4.1", | ||
| "y-indexeddb": "^9.0.11-multiplex.0", | ||
|
||
| "y-protocols": "^1.0.6", | ||
| "yallist": "^5.0.0", | ||
| "yjs": "^13.6.27" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually need the
#feat/add-typesbranch from GoogleChromeLabs/page-lifecycle#12.v0.1.2is missing type definitions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you check this part please?
I just replace with the version from the code.
https://github.com/magic-akari/page-lifecycle/blob/50b50421bdeab3d211a57e81a277f699638373b0/package.json#L3
And real reference is declared in
resolutionobject.This means the modules will be fetch from tarball link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I forgot about resolutions! Do you know of any way to make this clearer for other developers? They might make the same mistake as me and not realize that it doesn't use the version listed in the package.json.
If resolutions overrides the package source, can we put any value there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about add special explanation in readme?
Regardless of what we put in dependencies, the resolutions value will be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README is too far away for it to be useful for this kind of thing. It needs to be co-located.
If the dependency value is ignored, I would recommend putting a dummy value that points to resolutions. I'm not sure if this is very conventional, but I can't think of a better way. It would be misleading otherwise.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about removing values from resolution and use direct value into dependency values?
https://github.com/cybersemics/em/pull/3262/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R114
https://github.com/cybersemics/em/pull/3262/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could work, though that just obscures it in the other direction, making it hard to know where the actual source code for the dependencies lives.