-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(server): retry cloud requests on HTTP 500 #33718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3dd0481
fix(server): retry cloud requests on HTTP 500
mschile 8d6910b
chore: add changelog entry
mschile 9beece2
chore: move changelog entry to 15.14.3 section
mschile daacbce
test(system-tests): update 500 retry behavior
mschile 116cdd3
Merge remote-tracking branch 'origin/develop' into mschile/amazing-ho…
mschile 1f87fc6
Merge remote-tracking branch 'origin/develop' into mschile/amazing-ho…
mschile e64dfd2
Merge remote-tracking branch 'origin/develop' into mschile/amazing-ho…
mschile 1ff8920
Merge branch 'develop' into mschile/amazing-hodgkin-06f561
mschile 9154fa0
fix(server): scope HTTP 500 retry to Test Replay artifact uploads
mschile 6a3a644
fix(server): make isRetryableError method-aware for HTTP 500 retries
mschile feda8c9
docs: cite RFC 9110 for idempotent method list
mschile 89fb519
Merge branch 'develop' into mschile/amazing-hodgkin-06f561
mschile d2e1c63
Apply suggestion
mschile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
fix(server): retry cloud requests on HTTP 500
Add 500 to the list of retryable HTTP status codes in `isRetryableError` to align with the sibling `isRetryableCloudError` in `cloud_request.ts`, which already treats 500 as a transient/retryable response.
- Loading branch information
commit 3dd04816209392b0bc9f0599300faa6180317794
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.