Skip to content

Visibility false to style='transform: scale(0,0)' or style='tra… #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 5, 2019
Merged

Visibility false to style='transform: scale(0,0)' or style='tra… #5590

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
631dd21
Handle elements hidden by scale.
sainthkh Nov 3, 2019
b907e2d
Check rotateX(90deg), rotateY(90deg) + Use of getBoundingClientRect
sainthkh Nov 4, 2019
4bbece0
Added reason message.
sainthkh Nov 4, 2019
a7666a7
Merge branch 'develop' into issue-723
sainthkh Nov 13, 2019
4d413bc
Fixed typo.
sainthkh Nov 27, 2019
335649d
Merge remote-tracking branch 'upstream/develop' into issue-723
sainthkh Nov 27, 2019
9ecdd20
Use numberRegex created for backface-visibility.
sainthkh Nov 27, 2019
acf7228
Added test for reason message.
sainthkh Nov 27, 2019
8c31575
Merge branch 'develop' into issue-723
sainthkh Dec 3, 2019
476c0b6
Added missing message test in #5591
sainthkh Dec 3, 2019
9d74096
Merge branch 'develop' into issue-723
chrisbreiding Dec 3, 2019
45296c5
Merge branch 'develop' into issue-723
chrisbreiding Dec 3, 2019
ce37a62
Merge branch 'develop' into issue-723
chrisbreiding Dec 4, 2019
8bed3b6
Merge branch 'develop' into issue-723
chrisbreiding Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added reason message.
  • Loading branch information
@sainthkh
sainthkh committed Nov 4, 2019
commit 4bbece02d20c20234ac77cd65c09c7445717a8a0
4 changes: 4 additions & 0 deletions packages/driver/src/dom/visibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,10 @@ const getReasonIsHidden = function ($el) {
return `This element '${node}' is not visible because it has an effective width and height of: '${width} x ${height}' pixels.`
}

if (elIsHiddenByTransfrom($el)) {
return `This element '${node}' is not visible because it is hidden by transform.`
}

if ($parent = parentHasNoOffsetWidthOrHeightAndOverflowHidden($el.parent())) {
parentNode = $elements.stringify($parent, 'short')
width = elOffsetWidth($parent)
Expand Down