Skip to content

fix: cy.visit() allows the URLs with double dots. #8629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flotwig merged 6 commits into from
Sep 25, 2020
Merged

fix: cy.visit() allows the URLs with double dots. #8629

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a215112
Fix
sainthkh Sep 21, 2020
ccf1e06
use URL for various Location methods
flotwig Sep 22, 2020
107a993
clean up
flotwig Sep 22, 2020
3a9a85e
restore qualifyWithBaseUrl - it qualifies against non-empty paths
flotwig Sep 22, 2020
8e135c8
Merge branch 'develop' into issue-5090
flotwig Sep 23, 2020
3a1deb7
Merge branch 'develop' into issue-5090
flotwig Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore qualifyWithBaseUrl - it qualifies against non-empty paths
  • Loading branch information
@flotwig
flotwig committed Sep 22, 2020
commit 3a9a85eeaa32ee61525635d51ceabfb8dcb226b0
10 changes: 8 additions & 2 deletions packages/driver/src/cypress/location.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class $Location {
}

static fullyQualifyUrl (url) {
return $Location.resolve(window.location.origin, url)
return this.resolve(window.location.origin, url)
}

static mergeUrlWithParams (url, params) {
Expand Down Expand Up @@ -192,7 +192,13 @@ class $Location {
}

static qualifyWithBaseUrl (baseUrl, url) {
return $Location.resolve(baseUrl, url)
// if we have a root url and our url isnt full qualified
if (baseUrl && !this.isFullyQualifiedUrl(url)) {
// prepend the root url to it
url = this.join(baseUrl, url)
}

return this.fullyQualifyUrl(url)
}

static isAbsoluteRelative (segment) {
Expand Down