Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

Conversation

@samvantran
Copy link
Contributor

What changes were proposed in this pull request?

Fixes: DCOS-41319

This updates the manifest.json URI to the standard downloads.mesosphere.com/spark/assets path.

How was this patch tested?

@samvantran samvantran changed the title [DCOS-41319] Use standard mesosphere manifest.json URI [DCOS-41319] Use standard mesosphere manifest URI Sep 5, 2018
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment regarding the SNAPSHOT versions.

"default_spark_dist": {
"hadoop_version": "2.6",
"uri": "svt-dev.s3.amazonaws.com/spark/spark-2.2.1-bin-2.6.5-DCOS-38138.tgz"
"uri": "https://downloads.mesosphere.com/spark/assets/spark-2.2.1-3-SNAPSHOT-bin-2.6.tgz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a SNAPSHOT version. Is that intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I still have to merge in Susan's Hive changes before we release the spark package. Once that's in I'll create the 2.2.1-3 tarball.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose my question is whether this is generated by the build process -- so that we don't have to manually update this each time. I'm not saying that we have to do it now, but it may make sense to file a ticket to get this working in a better way.

Copy link
Contributor Author

@samvantran samvantran Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not generated by build process, all manual right now. Your point is totally valid - created ticket for that future work DCOS-41439

Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the follow-up ticket.

@samvantran samvantran merged commit cb86d10 into master Sep 7, 2018
@samvantran samvantran deleted the 41319-fix-uri branch September 7, 2018 16:19
samvantran added a commit that referenced this pull request Sep 7, 2018
This updates the `manifest.json` URI to the standard `downloads.mesosphere.com/spark/assets` path
samvantran added a commit that referenced this pull request Sep 18, 2018
Backport of #388 && #405

This commit makes it possible to pass multi-argument configuration strings in the spark-cli.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants