-
Notifications
You must be signed in to change notification settings - Fork 33
[DCOS-41319] Use standard mesosphere manifest URI #405
Conversation
elezar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment regarding the SNAPSHOT versions.
| "default_spark_dist": { | ||
| "hadoop_version": "2.6", | ||
| "uri": "svt-dev.s3.amazonaws.com/spark/spark-2.2.1-bin-2.6.5-DCOS-38138.tgz" | ||
| "uri": "https://downloads.mesosphere.com/spark/assets/spark-2.2.1-3-SNAPSHOT-bin-2.6.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a SNAPSHOT version. Is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I still have to merge in Susan's Hive changes before we release the spark package. Once that's in I'll create the 2.2.1-3 tarball.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose my question is whether this is generated by the build process -- so that we don't have to manually update this each time. I'm not saying that we have to do it now, but it may make sense to file a ticket to get this working in a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not generated by build process, all manual right now. Your point is totally valid - created ticket for that future work DCOS-41439
elezar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the follow-up ticket.
This updates the `manifest.json` URI to the standard `downloads.mesosphere.com/spark/assets` path
What changes were proposed in this pull request?
Fixes: DCOS-41319
This updates the
manifest.jsonURI to the standarddownloads.mesosphere.com/spark/assetspath.How was this patch tested?