Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

Conversation

@akirillov
Copy link
Contributor

What changes were proposed in this pull request?

Resolves DCOS-46369

If Spark Dispatcher is started with a network name specified - it runs all submitted Spark Application within the same network until another network is specified.

  • added mapping of virtual network name and labels to environment variables in mustache template
  • if spark.mesos.network.name and/or spark.mesos.network.labels are specified - they're added to mesos-cluster-dispatcher.properties on dispatcher start

How were these changes tested?

  • New integration tests for all combinations of containerizers for Dispatcher and Driver/Executors verifying the behavior

Release Notes

  • Spark Dispatcher (by default) launches Spark Drivers and Executors in the same virtual network it was launched in itself

Copy link
Contributor

@samvantran samvantran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
++ for using parameterized tests

"default_spark_dist": {
"hadoop_version": "2.7",
"uri": "https://downloads.mesosphere.com/spark/assets/spark-2.3.2-SNAPSHOT-3-bin-2.7.7.tgz"
"uri": "https://downloads.mesosphere.com/spark/assets/spark-2.3.2-SNAPSHOT-4-bin-2.7.7.tgz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not something for this PR but just making a note for us that we should probably timestamp these jars (when we build in CI)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, this is pretty painful when the changes happen in both Spark and spark-build. This should be overridden in the CI e.g. by means of env var passed to Makefile, and version update in manifest committed prior to merge.

@akirillov akirillov force-pushed the DCOS-46369-dispatcher-network-defaults-for-spark-applications branch from a811b4a to 5fd1c2d Compare January 16, 2019 22:58
@akirillov akirillov force-pushed the DCOS-46369-dispatcher-network-defaults-for-spark-applications branch from 5fd1c2d to a1759a7 Compare January 17, 2019 02:12
@akirillov akirillov merged commit 6481023 into master Jan 17, 2019
@vishnu2kmohan vishnu2kmohan deleted the DCOS-46369-dispatcher-network-defaults-for-spark-applications branch February 19, 2019 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants