This repository was archived by the owner on Oct 23, 2024. It is now read-only.
forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 7
[DCOS-46585] Fix supervised driver retry logic for outdated tasks #46
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8ebff3b
Fix scalastyle error for multiline comment
samvantran a05c2f1
WIP: checking if task already relaunched via ZK
samvantran c43545b
WIP updating test to reflect IRL scenario
samvantran 798c3c8
Bingo
samvantran 70ba913
Cleanup log messages
samvantran 473bf1b
Simplify the logic
samvantran 712d3fd
Cleanup + revert accidental changes
samvantran 58f3f74
Track retriedDrivers via HashSet
samvantran b7b25e7
Merge branch 'custom-branch-2.3.x' into 46585-duplicate-retries
samvantran 361699d
Better solution: check in launched and pending drivers
samvantran b2a694d
Add scaladoc for taskIsOutdated method
samvantran 4b65983
Merge branch 'custom-branch-2.3.x' into 46585-duplicate-retries
samvantran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Track retriedDrivers via HashSet
This frees us from parsing retry counts from strings and future proofs us in the event taskId UUID ever changes
- Loading branch information
commit 58f3f746ee15db8792323f90b9e65e17b9852bb0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having state mutation logic in a boolean function which checks some condition looks a bit confusing