Fix UP action arrow drawn as LEFT in FrozenLake visualizations#2694
Open
Chessing234 wants to merge 1 commit into
Open
Fix UP action arrow drawn as LEFT in FrozenLake visualizations#2694Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
In both show_value_function_progress and show_Q_function_progress, action 3 (UP) is mapped to (-.25, 0) which is identical to action 0 (LEFT). The correct direction for UP in imshow coordinates (where y increases downward) is (0, -.25). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
show_value_function_progressandshow_Q_function_progress, theaction2dxdydictionary maps action 3 (UP) to(-.25, 0), which is identical to action 0 (LEFT). Every cell whose optimal action is UP displays a left-pointing arrow instead of an up-pointing arrow.The correct mapping for UP in
imshowcoordinates (where y increases downward) is(0, -.25), consistent with DOWN being(0, .25).Before: Actions 0 (LEFT) and 3 (UP) both draw arrows pointing left.
After: Action 3 (UP) correctly draws an upward arrow.
Fixed in all four occurrences across
d2l/torch.pyandchapter_appendix-tools-for-deep-learning/utils.md.Test plan
🤖 Generated with Claude Code