Adds the ability to change the default value of missing request_id #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingbuzzman
changed the title
|
On further inspection I see that issue #28 has nothing to do with this, as that relates to a missing middleware entry. Please let me know if there is anything else you want me to do, thanks. |
log_request_id/session.py
Outdated
| request_id = local.request_id | ||
| except AttributeError: | ||
| request_id = NO_REQUEST_ID | ||
| request_id = DEFAULT_NO_REQUEST_ID |
There was a problem hiding this comment.
Should this not be using the user-overidable value? Something like getattr(settings, LOG_REQUESTS_NO_SETTING, DEFAULT_NO_REQUEST_ID)
There was a problem hiding this comment.
Yes this is true, i dont use this part, but youre right. I'll change it.
There was a problem hiding this comment.
Ok done, i should probably add a test, let me see where to put it.
There was a problem hiding this comment.
Turns out there was no need for this, NO_REQUEST_ID is excluded from being sent anyways. I reworked it.
RealOrangeOne
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of logs, including in celery workers. These workers as you can imagine won't ever have a
request_id, in order to keep all our logs looking the same we normally put-as the missing value of our filters, nginx i think does the same, either way most of our filters default to that and yours is the only one that hasnoneon it.