Skip to content

Conversation

@subutux
Copy link
Contributor

@subutux subutux commented Apr 13, 2022

This looks trough the deployed scale apps and checks if the ingress is enabled and TLS is active. If so, update the certificate ID to the new one.

This looks trough the deployed scale apps and checks if the ingress is enabled and TLS is active. If so, update the certificate ID to the new one.
@danb35 danb35 merged commit 0f83981 into danb35:master Apr 14, 2022
@AidanGG
Copy link

AidanGG commented Jul 31, 2022

I'm receiving the following error (TrueNAS-SCALE-22.02.2.1):

Traceback (most recent call last):
  File "/root/deploy-freenas/./deploy_freenas.py", line 280, in <module>
    if config['ingress']['main']['enabled'] and len(config['ingress']['main']['tls']) > 0:
KeyError: 'ingress'

Perhaps something changed in a recent SCALE update?

@subutux
Copy link
Contributor Author

subutux commented Aug 1, 2022

Hi,

I noticed the same issue. If I got the time later today, I'll take a look. I don´t think this has anything todo with a recent update because I didn't upgrade, just a coding error in detecting if a scale app is using the TLS setting.

maybe a quick fix can be to change the line 280 to the following:

if config.get("ingress", False) and config['ingress']['main']['enabled'] and len(config['ingress']['main']['tls']) > 0:

That should fix the issue. I can´t test it right now tho.

@AidanGG
Copy link

AidanGG commented Aug 1, 2022

That seems to fix my issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants