Skip to content

Bug fix: deletion of old certs fails #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danb35 merged 2 commits into from
Jan 24, 2023
Merged

Bug fix: deletion of old certs fails #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394e4a7
Bug fix: Remove unnecessary double quotation marks.
adorobis Jan 24, 2023
a32d74f
Merge branch 'danb35:master' into master
adorobis Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy_freenas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@
cert_ids_expired = set()
for cert_data in cert_list:
if set(cert_data['san']) == set(new_cert_data['san']):
if cert_data['name'].startswith("CERT_BASE_NAME"):
if cert_data['name'].startswith(CERT_BASE_NAME):
cert_ids_same_san.add(cert_data['id'])

if not cert_data['cert_type_CSR']:
Expand Down