Update deploy_freenas.py #70
Conversation
Seems acme has updated and the previous deploy_freenas.py doesn't work on my TrueNAS Core, which is the latest version. So I add segment"_ecc" in line 52&53 to stay in line with the latest acme format.
jjijack
force-pushed
the
patch-1
branch
2 times, most recently
from
3373002 to
3aa4025
Compare
Of course it will--it's just that the default paths used by this script for the cert and key no longer match the defaults used by acme.sh, so you'd need to specify them in your config file. Not that updating the script to correctly handle the new defaults is a bad thing, if it can be done without breaking existing installations (which simply changing the script's defaults would have). But I'm wondering about the logic of your patch. It looks like:
...and then do the same for the full chain. Am I following it correctly? Because if so, it seems like the second attempt use the setting from the config file is kind of redundant. |
I understand, so I added try/except structure to handle both old and new format later. I believe the update won't break existing installations.
Yes you are right. I copied and pasted part of the code, and it's indeed a little redundant. I can optimize the code to make it more elegant. |
Use os.path.isfile, rather than try open to determine whether a file exists. Now the config would only be read once. Update deploy_config.example to contain both new and old acme route
2 participants
I began to use this script recently and installed the latest acme with default settings. However, it seems that acme has updated (like this) and the current version of deploy_freenas.py doesn't work on my device. So I add suffix "_ecc" in line 52&53 to stay in line with the latest acme format.