Update deploy_truenas.py #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the default protocol value. Was ws and is now wss.
Author
|
Correct the default protocol value. Was ws and is now wss. |
Owner
|
I don't believe this change is necessary, and it will cause the script to fail with a stock TrueNAS installation unless you also set |
Owner
|
Hearing no argument for why this change needs to be made, I'm closing this PR. If you'd like to resubmit, please include an explanation for you believe it to be necessary, and make sure the README and example config file are also updated accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the default protocol value. Was ws and is now wss.