Skip to content

fix(svg/filter): add baseurl prop #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilowoz merged 3 commits into from
Mar 7, 2019
Merged

fix(svg/filter): add baseurl prop #144

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b4b603
fix(svg/filter): add baseurl prop
danilowoz Mar 7, 2019
92e181f
test(baseurl): add tests
danilowoz Mar 7, 2019
333b04e
docs(prop): baseurl
danilowoz Mar 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs(prop): baseurl
  • Loading branch information
@danilowoz
danilowoz committed Mar 7, 2019
commit 333b04ea24211314d1eab74ca5a20a39de661545
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ Defaults to `true`. Opt-out of animations with `false`

Defaults to `Loading interface...`. It's used to describe what element it is. Use `false` to remove.

**`baseUrl? string`**

Required if you're using `<base url="/" />` in your `<head/>`. Defaults to an empty string. This prop is commom used as: `<ContentLoader baseUrl={window.location.pathname} />` which will fill the svg attribute with the relative path. Related [#93](https://github.com/danilowoz/react-content-loader/issues/93).

**`speed?: number`**

Defaults to `2`. Animation speed in seconds.
Expand Down
8 changes: 8 additions & 0 deletions docs/props.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ Defaults to `Loading interface...`. It's used to describe what element it is. Us
<Facebook ariaLabel="my custom loader" />
</Playground>

## **`baseUrl? string`**

Required if you're using `<base url="/" />` in your `<head/>`. Defaults to an empty string. This prop is commom used as: `<ContentLoader baseUrl={window.location.pathname} />` which will fill the svg attribute with the relative path. Related [#93](https://github.com/danilowoz/react-content-loader/issues/93).

<Playground>
<Facebook baseUrl="/mypage" />
</Playground>

## `speed?: number`

Defaults to `2`. Animation speed in seconds.
Expand Down