Skip to content

Conversation

danilowoz
Copy link
Owner

@danilowoz danilowoz commented Jan 17, 2020

  • Update key name of primaryColor and secondaryColor for something more meaningful, maybe backgroundColor and foregroundColor;
  • Revisit width/height keys and if it really necessary to apply on viewBox attr its values;
  • When viewBox is set up, the svg is truncated, see fix(native/svg.tsx): svg is truncated when using a ViewBox -react-native #173;
  • Check aria-* is used right;
  • Rename the key name of uniquekey for something more meaningful, maybe id, or loadingId;
  • Remove uncessary keys: preserveAspectRatio, className...
  • Name the export of the main component (SVG);
  • Reduce bundle as much as it possible;
  • Update test (aria);

BREAKING CHANGE: Rename `primaryColor` to `backgroundColor` and `secondaryColor` to
`foregroundColor`.
@danilowoz danilowoz force-pushed the v5 branch 2 times, most recently from 5606874 to a85f02a Compare January 17, 2020 14:27
BREAKING CHANGE: Renamed prop key `uniquekey` to `uniqueKey`
BREAKING CHANGE: Shift `ariaLabel` to `title` prop, the value remains
@danilowoz
Copy link
Owner Author

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants