Skip to content

Conversation

NikolaIliev
Copy link
Contributor

BREAKING CHANGE: The current delay is same as the speed. After the change it is a quarter of the
speed by default.

Summary

Implement 'interval' prop for RN. It was only available on web.

Any Breaking Changes

Before this change, the interval prop was not supported and, in the RN version, there was a default delay equal to the speed of the animation, in the RN version of this module. Now that it is supported, we either have to leave the default behavior as it was (which means interval should have a default value of 1) or implement the same default behavior that web has (interval should have a default value of 0.25). The former is not a breaking change but introduces a discrepancy between web/RN and will be confusing for future users. The latter is a breaking change fo
r React Native users.

Checklist

  • Are all the test cases passing?
  • [] If any new feature has been added, then are the test cases updated/added?
  • Has the documentation been updated for the proposed change, if required?

BREAKING CHANGE: The current delay is same as the speed. After the change it is a quarter of the
speed by default.
@NikolaIliev
Copy link
Contributor Author

@danilowoz Should we make the RN default 0.25, same as web, thereby introducing a breaking change?

Or keep it at 1, without a breaking change, but with a discrepancy between RN and web?

What do you think?

@danilowoz
Copy link
Owner

Sorry @NikolaIliev for the late answer.
I'd try as hard as we can keeping the same API and values across platforms, in order to make it more consistently. If it introduces any break changes, there is no problem, IMO.

So, in your opinion, does it ready to be merged?

Thanks for the changes BTW, makes totally sense.

@NikolaIliev
Copy link
Contributor Author

NikolaIliev commented Jan 14, 2021

You're welcome! Thanks for creating this module, I put it to good use :)

It should be ready to merge yes, the default value is the same as web currently.

@danilowoz danilowoz merged commit c6da59d into danilowoz:master Jan 14, 2021
@github-actions
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants