🔧 fix: Delete Archived Chat z-index issue#3643
Conversation
|
wait before merging this, I've probably already fixed this in a bigger branch |
|
@berry-13 can you specify which branch? Fixes like this should be scoped like this PR |
|
FYI resolved the conflicts introduced by PRs merged before this one, so this branch is mergeable again. I'm not sure if @berry-13's bigger branch makes the z-index fix obsolete or not. FWIW I did search the issues and open PRs to see if anyone was working on this issue, so I think that's another good reason to more tightly scope PRs moving forward. It helps the rest of us know if an issue is known and being worked on. |
|
thanks, agreed! |
|
@arthurian hey, sorry I missed replying to both you and Danny. Can you let me know which browser you were using for the test? The OGDialog shouldn't have this issue |
|
I was using the Chrome browser for testing if that helps. |
Summary
This PR fixes a UI issue in Settings > General > Archived Chats > Manage where users can't delete an archived chat because the Delete chat? dialog is hidden. The problem is that the z-order was changed at some point, causing the Delete chat? dialog to be stacked behind the Archived chats table (z-index 50 < 999).
This PR updates the
z-indexon the dialog so that the ordering is as follows:z-index: autoz-index: 999z-index: 1000changed fromz-index: 50Change Type
Testing
I tested these changes locally and verified the z-order in the browser using standard devtools. Screenshots included below for reference.
Before the change:
After the change:
Test Configuration:
No special configuration required to test, just create a conversation, archive it, and then attempt to delete it.
Checklist