Skip to content

🪖 refactor: Helm chart release workflow#4311

Merged
danny-avila merged 1 commit into
danny-avila:mainfrom
pranshu-m:main
Oct 3, 2024
Merged

🪖 refactor: Helm chart release workflow#4311
danny-avila merged 1 commit into
danny-avila:mainfrom
pranshu-m:main

Conversation

@pranshu-m

@pranshu-m pranshu-m commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

Summary

The current setup allows the Helm chart workflow to execute, but the charts are not being released as expected. The helm/chart-releaser-action@v1.6.0 requires a specific directory structure to function correctly:

Copy code
charts/
    chart1/
        templates/
        Chart.yaml
    chart2/

To align with industry standards, I have renamed the folder from helmchart to charts to ensure consistency with best practices.

Our org uses a different helm chart, we would prefer to use one present in this repo

In future PRs will add more improvements, keeping this one independent of code changes

Change Type

Please delete any irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Translation update

Testing

Reformatting to allow helm chart release, no chart templates were updated

Test Configuration:

Checklist

Please delete any irrelevant options.

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • A pull request for updating the documentation has been submitted.

@danny-avila danny-avila changed the title Fix Helm chart release workflow 🪖 refactor: Helm chart release workflow Oct 3, 2024
@danny-avila

Copy link
Copy Markdown
Owner

Thanks!

@danny-avila danny-avila merged commit cb0b69e into danny-avila:main Oct 3, 2024
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
MichielMAnalytics pushed a commit to MichielMAnalytics/ProAI that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants