Merged
Conversation
danschultzer
force-pushed
the
use-finch
branch
from
31b3a33 to
e9e4659
Compare
danschultzer
force-pushed
the
use-finch
branch
from
e9e4659 to
4be7b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue persisted when using the
Bandit.HTTP2.Adapter, and anyPlug.Conncalls where the process will wait for any messages to have been received. With theBandit.HTTP2.Adapterthe expectation is that thePlug.Connfunction calls happens within the same process as where the plug for initially called. This is different from howPlug.CowboyandBandit.HTTP1is handled.This PR resolves this issue by encapsulating all
Plug.Conncalls whenBandit.HTTP.Adapteris used in the conn. @mtrudel has indicated that this might be handled differently post Bandit 1.0.0 release, so this could be removed in the future.More details on the issues I experienced using TestServer with Bandit and HTTP/2:
mtrudel/bandit#215
mtrudel/bandit#101