Skip to content

Fixes compilation warning from Instance.handle_call/3#17

Merged
danschultzer merged 3 commits intodanschultzer:mainfrom
antedeguemon:vm-fixes-handle-call-warning
Nov 18, 2023
Merged

Fixes compilation warning from Instance.handle_call/3#17
danschultzer merged 3 commits intodanschultzer:mainfrom
antedeguemon:vm-fixes-handle-call-warning

Conversation

@antedeguemon
Copy link
Contributor

@antedeguemon antedeguemon commented Nov 17, 2023

Hey! 🖖

This pull request:

  • Groups Instance.handle_call/3 together to fix the warning
  • Adds a new CI step to verify for compilation warnings

I caught the warning log when compiling a project that depends on test_server:

==> test_server
Compiling 12 files (.ex)
     warning: clauses with the same name and arity (number of arguments) should be grouped together, "def handle_call/3" was previously defined (lib/test_server/instance.ex:184)246def handle_call(
     │       ~
     │
     └─ lib/test_server/instance.ex:246:7

@antedeguemon antedeguemon changed the title Fixes compilation warning for Instance.handle_call/3 Fixes compilation warning from Instance.handle_call/3 Nov 17, 2023
@danschultzer
Copy link
Owner

Thanks ❤️

@danschultzer danschultzer merged commit fa41136 into danschultzer:main Nov 18, 2023
@antedeguemon antedeguemon deleted the vm-fixes-handle-call-warning branch November 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants