Skip to content

rename feedback view to return success messages after running queries that do not return anything#275

Merged
danvergara merged 1 commit intomainfrom
add-feedback-view
Oct 17, 2025
Merged

rename feedback view to return success messages after running queries that do not return anything#275
danvergara merged 1 commit intomainfrom
add-feedback-view

Conversation

@danvergara
Copy link
Owner

Add feedback page

Description

This PR introduces a new feedback view to provide users with more informative messages about the execution of their SQL queries. Previously, the UI only had an error page, which was displayed for both errors and successful queries that didn't return any rows. This could be confusing for users.

The new feedback view replaces the error page and provides the following features:

  • Displays error messages in red when a query fails.
  • Displays a success message in green when a query is executed successfully but doesn't return any rows.
  • The content page is displayed as usual when the query returns results.

This change improves the user experience by providing clearer feedback on the query execution status.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have tested this feature by running the following queries:

  • A query that returns results.
  • A query that returns no results (e.g., SELECT * FROM users WHERE 1 = 0).
  • A query that produces an error (e.g., SELECT * FROM non_existent_table).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@danvergara danvergara merged commit 5ec410b into main Oct 17, 2025
4 checks passed
@danvergara danvergara deleted the add-feedback-view branch October 17, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant