Add baggage header support to http binding #3723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cassandra Coyle <[email protected]>
JoshVanL
requested changes
Apr 2, 2025
| } | ||
| if baggage, ok := req.Metadata[BaggageHeaderKey]; ok && baggage != "" { | ||
| if _, ok := request.Header[http.CanonicalHeaderKey(BaggageHeaderKey)]; ok { | ||
| h.logger.Warn("Tracing is enabled. A custom Baggage request header cannot be specified and is ignored.") |
Contributor
There was a problem hiding this comment.
Should this not break out of the outer if?
Contributor
Author
There was a problem hiding this comment.
The current implementation aligns with how traceparent and tracestate headers work (if you look above).
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
antontroshin
approved these changes
Apr 22, 2025
nelson-parente
approved these changes
Apr 23, 2025
yaron2
approved these changes
Apr 23, 2025
jjcollinge
pushed a commit
to jjcollinge/components-contrib
that referenced
this pull request
May 12, 2025
Signed-off-by: Cassandra Coyle <[email protected]>
Contributor
|
@holopin-bot @cicoyle Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @cicoyle, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmbs0eq4p161707l9ialzyagh This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution for this issue