Skip to content

Conversation

WhitWaldo
Copy link
Contributor

@WhitWaldo WhitWaldo commented Aug 14, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

I noticed that the published page listing the various environment variables was missing two of the values used today: DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT, so I've added them to the list.

Issue reference

N/A

@WhitWaldo WhitWaldo requested review from a team as code owners August 14, 2024 14:43
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WhitWaldo - These are great missing additions. See my comments on examples to help developers.

Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo
Copy link
Contributor Author

@msfussell For both examples, I'll come back and edit the language in the docs if/when another PR I created today is accepted and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants