Enable vault name mapping and error suppression#1051
Closed
yash-nisar wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
halspang
requested changes
Mar 29, 2023
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Seems good overall, just a few comments.
| } | ||
|
|
||
| [Fact] | ||
| public void LoadSecrets_FromSecretStoreWithADifferentSecretKeyAndName() |
Contributor
There was a problem hiding this comment.
We should really have a test for required = false as well.
4 tasks
3 tasks
Contributor
Author
|
Closing in favour of #887. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable vault name mapping and error suppression
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #887
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: