Add support to DAPR_HTTP_ENDPOINT and DAPR_GRPC_ENDPOINT env.#1124
Merged
Conversation
artursouza
commented
Jul 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 67.22% 67.16% -0.06%
==========================================
Files 170 170
Lines 5687 5695 +8
Branches 605 607 +2
==========================================
+ Hits 3823 3825 +2
- Misses 1723 1727 +4
- Partials 141 143 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
halspang
requested changes
Jul 10, 2023
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Small changes for the comments, overall it looks good.
Contributor
|
@artursouza - Can you fix your DCO? |
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Contributor
Author
Fixed. |
halspang
approved these changes
Jul 18, 2023
onionhammer
pushed a commit
to onionhammer/dotnet-sdk
that referenced
this pull request
Aug 22, 2023
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1110
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: