-
Notifications
You must be signed in to change notification settings - Fork 371
Enable vault name mapping and error suppression #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
840a763
Added documentation detailing how serialization works using the DataC…
WhitWaldo 6337367
Weakly typed actor polymorphic and null responses (#1214)
RemcoBlok 4e2443c
Enable vault name mapping and error suppression
yash-nisar 2b4b44d
Add additional secret descriptor constructor for required without key…
jamesmcroft fefdfcb
Update configuration load exception rethrow to match rules
jamesmcroft 4adc7be
Add tests for required/not required exception handling
jamesmcroft 39f8190
Implementing Cryptography building block in .NET (#1217)
WhitWaldo 4a0a1e7
Update DaprSecretDescriptor constructors and documentation
jamesmcroft 0b55a35
Merge branch 'master' into vault-name-mapping
jamesmcroft 76f8a35
Remove DaprSecretStoreConfigurationProvider Console.WriteLine
jamesmcroft 57dd847
Merge branch 'master' into vault-name-mapping
philliphoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add additional secret descriptor constructor for required without key…
… map Signed-off-by: James Croft <jamz_c@hotmail.co.uk>
- Loading branch information
commit 2b4b44d5f1a6de08e8fcf20387a632cc4f38ee9e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making
isRequiredandsecretKeyboth optional arguments, to help reduce the explosion of constructor overloads as well as, say, allow users to only specify thesecretKeybut not have to then care about theisRequiredargument. We might also consider doing the same formetadata.Ideally these would all (save for
secretName) betinitproperties on the class, but that's a larger breaking change (depending on how many people actually specify metdata with each secret).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the constructor overload bloat and consolidated this change into the existing 2 constructors using optional arguments.