Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7ab916c
update devcontainer
paule96 Aug 27, 2024
5412da5
update test setup
paule96 Aug 27, 2024
4dc9fc3
Now the json serialization should work with multiple methods in an in…
paule96 Aug 28, 2024
a31531a
fixed devcontainer to run actors
paule96 Aug 28, 2024
a940c1c
fix bugs with the current implementation
paule96 Aug 28, 2024
a03ff46
add a test that checks excatly the behavior
paule96 Aug 28, 2024
a4222c9
fix devcontainer post creatd command
paule96 Aug 28, 2024
7be9077
change the default to dotnet 8.0
paule96 Sep 3, 2024
78764aa
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
yaron2 Sep 26, 2024
2d8d533
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Oct 10, 2024
24ce360
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Oct 17, 2024
e95a7f2
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Oct 18, 2024
8a721be
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Oct 22, 2024
698b837
I don't know what is different but we commit.
paule96 Oct 23, 2024
96ba8ad
make it easier to see why the application of an E2E test couldn't start
paule96 Oct 23, 2024
a7f0a92
make the exception in E2E more percise
paule96 Oct 24, 2024
9e34381
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Oct 28, 2024
00ad7d7
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Nov 4, 2024
de167bf
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Nov 14, 2024
d3e961c
Merge branch 'master' into bug/476_multiple_methods_per_interface_wit…
WhitWaldo Nov 30, 2024
9fc6fcd
fix exception message
paule96 Dec 3, 2024
9a74614
Merge remote-tracking branch 'origin/bug/476_multiple_methods_per_int…
paule96 Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix bugs with the current implementation
Signed-off-by: paule96 <paul-jeschke@outlook.com>
  • Loading branch information
paule96 committed Sep 3, 2024
commit a940c1c18aaf622e8f20569e11baddd2d3ebe42f
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ public MemoryStreamMessageBodySerializer(
{
var _methodRequestParameterTypes = new List<Type>(methodRequestParameterTypes);
var _wrappedRequestMessageTypes = new List<Type>(wrappedRequestMessageTypes);
if(_wrappedRequestMessageTypes.Count != 1){
throw new NotSupportedException("JSON serialisation should always provide the actor method, that was called" +
if(_wrappedRequestMessageTypes.Count > 1){
throw new NotSupportedException("JSON serialisation should always provide the actor method (or nothing), that was called" +
" to support (de)serialisation. This is a dapr sdk error, open an issue on github.");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dapr" -> "Dapr"
"github" -> "GitHub"

}
this.serializerOptions = new(serializerOptions)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,14 @@ internal CacheEntry CreateSerializers((int interfaceId, string methodName) data)
else
{
// This path should be used for JSON serialization
var requestWrapperTypeAsList = new List<Type>(1){
interfaceDetails.RequestWrappedKnownTypes.Single(r => r.Name == $"{data.methodName}ReqBody")
};
var responseWrapperTypeAsList = new List<Type>(1){
interfaceDetails.RequestWrappedKnownTypes.Single(r => r.Name == $"{data.methodName}RespBody")
};
var requestWrapperTypeAsList = interfaceDetails.RequestWrappedKnownTypes.Where(r => r.Name == $"{data.methodName}ReqBody").ToList();
if(requestWrapperTypeAsList.Count > 1){
throw new NotSupportedException($"More then one wrappertype was found for {data.methodName}");
}
var responseWrapperTypeAsList = interfaceDetails.ResponseWrappedKnownTypes.Where(r => r.Name == $"{data.methodName}RespBody").ToList();
if(responseWrapperTypeAsList.Count > 1){
throw new NotSupportedException($"More then one wrappertype was found for {data.methodName}");
}
return new CacheEntry(
this.serializationProvider.CreateRequestMessageBodySerializer(serviceInterfaceType, requestBodyTypes, requestWrapperTypeAsList),
this.serializationProvider.CreateResponseMessageBodySerializer(serviceInterfaceType, responseBodyTypes, responseWrapperTypeAsList));
Expand Down