Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
85dbcf0
Added null check - the proto suggests this shouldn't ever be null, bu…
WhitWaldo Nov 28, 2024
054f6d9
Removed the Task.WhenAll making the operation non-blocking
WhitWaldo Nov 28, 2024
2eb6b5d
Added unit test to validate that the subscription is no longer blocking
WhitWaldo Nov 28, 2024
8593d8a
Removed unused line from previous test, added another test
WhitWaldo Nov 28, 2024
6465ad1
Added another test
WhitWaldo Nov 28, 2024
c92e46a
More unit tests
WhitWaldo Nov 28, 2024
0ccda6b
Added more unit tests
WhitWaldo Nov 28, 2024
09bec43
Updated to make DaprPublishSubscribeClientBuilder configurable via a …
WhitWaldo Nov 28, 2024
7900b0c
Added missing copyright statements
WhitWaldo Nov 28, 2024
0ae4919
Merge branch 'master' into pubsub-fix
WhitWaldo Nov 28, 2024
560aa2a
Added missing package reference
WhitWaldo Nov 28, 2024
95b102d
Merge remote-tracking branch 'origin/pubsub-fix' into pubsub-fix
WhitWaldo Nov 28, 2024
f864511
Fixed bad reference (missed in merge)
WhitWaldo Nov 28, 2024
51782b0
Fixed failing unit test
WhitWaldo Nov 28, 2024
e0b7de2
Tweak to only pass along EventMessage payloads to developers as it's …
WhitWaldo Nov 30, 2024
3e1df92
Merge branch 'master' into pubsub-fix
WhitWaldo Nov 30, 2024
1fce6b5
Was missing assignment of the Data property in the TopicMessage. Shou…
WhitWaldo Nov 30, 2024
4e71535
Merge remote-tracking branch 'origin/pubsub-fix' into pubsub-fix
WhitWaldo Nov 30, 2024
b2ab6ea
Fix - return would be bad. Continue is the right move.
WhitWaldo Nov 30, 2024
d48a85e
Added a simple test
WhitWaldo Dec 3, 2024
eea8546
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 3, 2024
fd2332c
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 4, 2024
b11cf16
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 4, 2024
be5a8a1
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 5, 2024
738f8be
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 10, 2024
35b8aca
Fixed unit tests
WhitWaldo Dec 11, 2024
31724b2
Merged in tweaks from #1422
WhitWaldo Dec 11, 2024
a08b7e8
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 11, 2024
b2ccb78
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 11, 2024
8fb65dd
Merge branch 'master' into pubsub-fix
WhitWaldo Dec 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak to only pass along EventMessage payloads to developers as it's …
…expected that the initial response will be null if EventMessage is populated

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
  • Loading branch information
WhitWaldo committed Nov 30, 2024
commit e0b7de2d7d9c392751f5965fe119686dcbccaaf4
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,8 @@ await stream.RequestStream.WriteAsync(
await foreach (var response in stream.ResponseStream.ReadAllAsync(cancellationToken))
{
//https://github.com/dapr/dotnet-sdk/issues/1412 reports that this is sometimes null
if (response?.EventMessage is null || response.InitialResponse is null)
//Skip the initial response - we only want to pass along TopicMessage payloads to developers
if (response?.EventMessage is null)
{
return;
}
Expand Down