Skip to content

Adds workflow replay-safe logger #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WhitWaldo merged 19 commits into from
Dec 19, 2024
Merged

Adds workflow replay-safe logger #1434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4404175
Removed obsolete type
WhitWaldo Oct 27, 2024
662b620
Added missing using
WhitWaldo Oct 27, 2024
cf876c0
Adding interface for IWorkflowContext for replayability concerns
WhitWaldo Oct 27, 2024
be5340a
Removed unused IConfiguration
WhitWaldo Oct 27, 2024
fcdeadf
Added ReplaySafeLogger type
WhitWaldo Oct 27, 2024
bcea844
Building out functionality to expose ReplayLogger in workflow context
WhitWaldo Oct 27, 2024
0a871f5
Added license information to file
WhitWaldo Dec 19, 2024
2a77908
Removed unnecessary file
WhitWaldo Dec 19, 2024
1d11d40
Updated copyright header for different project, made some tweaks for …
WhitWaldo Dec 19, 2024
ed19f04
Added virtual methods that use the already-available ILoggerFactory t…
WhitWaldo Dec 19, 2024
04a77a2
Removed unnecessary registration
WhitWaldo Dec 19, 2024
283e98d
Updated example to demonstrate using ReplaySafeLogger in the orchestr…
WhitWaldo Dec 19, 2024
182d58e
Tweaks on visibility and abstraction so that the methods are availabl…
WhitWaldo Dec 19, 2024
5f4a41b
Merge branch 'workflow-replay-logger' into workflow-logger
WhitWaldo Dec 19, 2024
3d6641e
Removed obsolete type registrations
WhitWaldo Dec 19, 2024
78ad0da
Simplified argument null check
WhitWaldo Dec 19, 2024
1d3f06f
Removed since-removed code leftover from merge
WhitWaldo Dec 19, 2024
4f32540
Added documentation demonstrating how to access the replay-safe logger
WhitWaldo Dec 19, 2024
53da1d8
Removed unnecessary and separate ReplaySafeLogger in favor of method …
WhitWaldo Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed obsolete type 
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
  • Loading branch information
@WhitWaldo
WhitWaldo committed Oct 27, 2024
commit 4404175eb3642796fa88be362ea27211912c0f87
34 changes: 0 additions & 34 deletions src/Dapr.Workflow/WorkflowEngineClient.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/Dapr.Workflow/WorkflowServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ public static IServiceCollection AddDaprWorkflow(
serviceCollection.TryAddSingleton<WorkflowRuntimeOptions>();
serviceCollection.AddHttpClient();

#pragma warning disable CS0618 // Type or member is obsolete - keeping around temporarily - replaced by DaprWorkflowClient
serviceCollection.TryAddSingleton<WorkflowEngineClient>();
#pragma warning restore CS0618 // Type or member is obsolete
serviceCollection.AddHostedService<WorkflowLoggingService>();
serviceCollection.TryAddSingleton<DaprWorkflowClient>();
serviceCollection.AddDaprClient();
Expand Down