Support gRPC richer error model#1436
Conversation
jev-e
force-pushed
the
support-extended-error-info
branch
2 times, most recently
from
49214e7 to
c89af5b
Compare
|
@jev-e Could you please make sure you've signed all your commits? The DCO check has failed. |
jev-e
force-pushed
the
support-extended-error-info
branch
from
c89af5b to
b5eb7b8
Compare
Signed-off-by: jev-e <jev@jev.org.uk> Signed-off-by: jev <jacob@jev.org.uk>
…add test file. Signed-off-by: jev <jacob@jev.org.uk>
Signed-off-by: jev <jacob@jev.org.uk>
jev-e
force-pushed
the
support-extended-error-info
branch
from
b5eb7b8 to
96d83d4
Compare
|
No clue why after the rebase its reporting so many new + changed files, it was ten beforehand. |
…ultiple details Signed-off-by: jev jacob@jev.org.uk Signed-off-by: jev <jacob@jev.org.uk>
Signed-off-by: jev jacob@jev.org.uk Signed-off-by: jev <jacob@jev.org.uk>
Signed-off-by: jev jacob@jev.org.uk Signed-off-by: jev <jacob@jev.org.uk>
Signed-off-by: jev jacob@jev.org.uk Signed-off-by: jev <jacob@jev.org.uk>
signed-off-by: jev jacob@jev.org.uk Signed-off-by: jev <jacob@jev.org.uk>
jev-e
force-pushed
the
support-extended-error-info
branch
from
96d83d4 to
587039a
Compare
|
commit history and file weirdness should be fixed, just let github handle the master branch update. |
|
On the failing integration tests; I ran them locally and saw a similar failure. however after running the ones targeting /net 7 + then running the .net 6 again, they all pass successfully and I am unable to regenerate the same issue. Are there any known issues with these tests? I cant think what I have done (besides install commonProtos into dapr.common) that would cause a failing GRPC integration test. |
|
@jev-e I've got a few additional minor notes above if you don't mind taking a pass by them. |
Don't worry about the failures. The test runner in GitHub often fails at least one of the integration tests (error logs indicate it just times out during setup) and it's easily re-run (as I just did). Usually if you pass at least one of the integration tests, you're good to go. |
WhitWaldo
left a comment
WhitWaldo
left a comment
There was a problem hiding this comment.
Neglected to submit my review - apologies!
Signed-off-by: jev <jacob@jev.org.uk>
|
@jev-e This looks good to me - let me know if you want me to wait on merging it until you add integration tests/speak with the runtime maintainers or you want to tackle that in a separate PR later (perhaps as part of the 1.16 push). |
Signed-off-by: jev <jacob@jev.org.uk>
|
@jev-e Thank you very much for your contribution! |
|
@holopin-bot @jev-e Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @jev-e, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qyj66y44490cmjtbyy8qpu This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
3 participants
Description
Provide a mechanism for users of the .NET SDK to obtain a Dapr implementation of the richer error model and extended error information.
Add an extension to DaprExtension that attempts to retrieve a
DaprExtendedErrorInfo, which contains a collection ofDaprExtendedErrorDetaileach of which is a mirror of its gRPC specification, and provides all properties provided by said specification.Add associated unit tests.
Update daprdocs in relation to the .NET SDK, providing an error handling section, which in turn provides an explanation of the richer error model, links to further reading, and details implementation in .NET SDK and example usage.
Issue reference
#1228 and #1227
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: