Test long vals #717
Merged
Test long vals #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: tanvigour <[email protected]>
Signed-off-by: Mukundan Sundararajan <[email protected]>
|
@tanvigour Please see this PR Draft ... |
tanvigour
previously approved these changes
Mar 29, 2022
|
closing this as a draft. |
Signed-off-by: Mukundan Sundararajan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
=========================================
Coverage 78.19% 78.19%
Complexity 1117 1117
=========================================
Files 97 97
Lines 3417 3417
Branches 399 399
=========================================
Hits 2672 2672
Misses 547 547
Partials 198 198 Continue to review full report at Codecov.
|
tanvigour
reviewed
Mar 31, 2022
flaky test |
|
Partially fixes #725 |
artursouza
approved these changes
Apr 1, 2022
artursouza
pushed a commit
that referenced
this pull request
Apr 1, 2022
* run IT test for long values Signed-off-by: tanvigour <[email protected]> * Fix the class name Signed-off-by: tanvigour <[email protected]> * assert for all messages and fix class name Signed-off-by: tanvigour <[email protected]> * test for Long.MAX_VALUE Signed-off-by: tanvigour <[email protected]> * revert back long number and print Signed-off-by: tanvigour <[email protected]> * fix the typo Signed-off-by: tanvigour <[email protected]> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <[email protected]> * log some more data to debug Signed-off-by: tanvigour <[email protected]> * debug Signed-off-by: tanvigour <[email protected]> * get the value from messages Signed-off-by: tanvigour <[email protected]> * fix long values assert Signed-off-by: Mukundan Sundararajan <[email protected]> * increasing TTL Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: tanvigour <[email protected]>
artursouza
pushed a commit
to pkedy/java-sdk
that referenced
this pull request
Jun 22, 2022
* run IT test for long values Signed-off-by: tanvigour <[email protected]> * Fix the class name Signed-off-by: tanvigour <[email protected]> * assert for all messages and fix class name Signed-off-by: tanvigour <[email protected]> * test for Long.MAX_VALUE Signed-off-by: tanvigour <[email protected]> * revert back long number and print Signed-off-by: tanvigour <[email protected]> * fix the typo Signed-off-by: tanvigour <[email protected]> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <[email protected]> * log some more data to debug Signed-off-by: tanvigour <[email protected]> * debug Signed-off-by: tanvigour <[email protected]> * get the value from messages Signed-off-by: tanvigour <[email protected]> * fix long values assert Signed-off-by: Mukundan Sundararajan <[email protected]> * increasing TTL Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: tanvigour <[email protected]> Signed-off-by: Artur Souza <[email protected]>
naah69
pushed a commit
to naah69/dapr-java-sdk
that referenced
this pull request
Jun 27, 2022
* run IT test for long values Signed-off-by: tanvigour <[email protected]> * Fix the class name Signed-off-by: tanvigour <[email protected]> * assert for all messages and fix class name Signed-off-by: tanvigour <[email protected]> * test for Long.MAX_VALUE Signed-off-by: tanvigour <[email protected]> * revert back long number and print Signed-off-by: tanvigour <[email protected]> * fix the typo Signed-off-by: tanvigour <[email protected]> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <[email protected]> * log some more data to debug Signed-off-by: tanvigour <[email protected]> * debug Signed-off-by: tanvigour <[email protected]> * get the value from messages Signed-off-by: tanvigour <[email protected]> * fix long values assert Signed-off-by: Mukundan Sundararajan <[email protected]> * increasing TTL Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: tanvigour <[email protected]> Signed-off-by: naah69 <[email protected]>
naah69
pushed a commit
to naah69/dapr-java-sdk
that referenced
this pull request
Jul 7, 2022
* run IT test for long values Signed-off-by: tanvigour <[email protected]> * Fix the class name Signed-off-by: tanvigour <[email protected]> * assert for all messages and fix class name Signed-off-by: tanvigour <[email protected]> * test for Long.MAX_VALUE Signed-off-by: tanvigour <[email protected]> * revert back long number and print Signed-off-by: tanvigour <[email protected]> * fix the typo Signed-off-by: tanvigour <[email protected]> * update the latest dapr commit in workflow files Signed-off-by: tanvigour <[email protected]> * log some more data to debug Signed-off-by: tanvigour <[email protected]> * debug Signed-off-by: tanvigour <[email protected]> * get the value from messages Signed-off-by: tanvigour <[email protected]> * fix long values assert Signed-off-by: Mukundan Sundararajan <[email protected]> * increasing TTL Signed-off-by: Mukundan Sundararajan <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: tanvigour <[email protected]> Signed-off-by: naah69 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the long values Test ...
Ran it 4 times in Github, did not fail once.
Basically I believe the change was the TTL seconds to 30 instead of 1. We are not testing TTL in this test.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: