Mark #sizeOf getter as synthetic in FFI struct transformation#62755
Mark #sizeOf getter as synthetic in FFI struct transformation#62755Gurleen-kansray wants to merge 2 commits intodart-lang:mainfrom
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/483400 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/483400 has been updated with the latest commits from this pull request. |
Closes dart-lang#62755 GitOrigin-RevId: ef98616 Change-Id: I1c2dafd605651241101edb6b1afd04528436cc68
|
https://dart-review.googlesource.com/c/sdk/+/483400 has been updated with the latest commits from this pull request. |
|
@Gurleen-kansray see the Gerrit CL for test failures. |
c91e44b to
6f23393
Compare
|
https://dart-review.googlesource.com/c/sdk/+/483400 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/483400 has been updated with the latest commits from this pull request. |
The #sizeOf getter generated by _addSizeOfGetter() in pkg/vm/lib/modular/transformations/ffi/definitions.dart is currently not marked as synthetic.
The corresponding #offsetOf getters in the same transformation are already marked with isSynthetic = true. For consistency, the #sizeOf getter should also be marked synthetic.
This issue was identified during GSoC 2026 exploration of the Native Memory Inspector project and suggested by Daco Harkes.
This change adds ..isSynthetic = true to the #sizeOf getter in _addSizeOfGetter().