Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Conversation

@xiaoch05
Copy link
Collaborator

No description provided.

@xiaoch05 xiaoch05 requested a review from wuminzhe March 27, 2021 07:24
@xiaoch05 xiaoch05 marked this pull request as ready for review March 27, 2021 07:24
@hackfisher
Copy link
Contributor

@xiaoch05 Would you please create/link the issue for the subxt's version problem which prevent from this to be used in test/production.

And please give the workaround solution you have if there is.

@xiaoch05
Copy link
Collaborator Author

@xiaoch05 Would you please create/link the issue for the subxt's version problem which prevent from this to be used in test/production.

And please give the workaround solution you have if there is.

the pr paritytech/substrate#7640 is not merged into the latest version v3.0.0, but darwinia-common used the master branch include this change.
subxt uses version 3.0.0, so it can't parse the new response of API getBlock.

this pr has no effect on this problem.
also, the latest version of darwinia-common can't work with bridger's master branch.

@xiaoch05
Copy link
Collaborator Author

@xiaoch05 Would you please create/link the issue for the subxt's version problem which prevent from this to be used in test/production.
And please give the workaround solution you have if there is.

the pr paritytech/substrate#7640 is not merged into the latest version v3.0.0, but darwinia-common used the master branch include this change.
subxt uses version 3.0.0, so it can't parse the new response of API getBlock.

this pr has no effect on this problem.
also, the latest version of darwinia-common can't work with bridger's master branch.

@hackfisher We have given a temporary solution by commit wuminzhe/substrate-subxt@c9163be

@hackfisher
Copy link
Contributor

hackfisher commented Apr 19, 2021

@xiaoch05 substrate-subxt's git commit in Cargo.lock should be updated to wuminzhe/substrate-subxt@c9163be

@xiaoch05
Copy link
Collaborator Author

@xiaoch05 Would you please create/link the issue for the subxt's version problem which prevent from this to be used in test/production.
And please give the workaround solution you have if there is.

the pr paritytech/substrate#7640 is not merged into the latest version v3.0.0, but darwinia-common used the master branch include this change.
subxt uses version 3.0.0, so it can't parse the new response of API getBlock.
this pr has no effect on this problem.
also, the latest version of darwinia-common can't work with bridger's master branch.

@hackfisher We have given a temporary solution by commit wuminzhe/substrate-subxt@c9163be

@xiaoch05 substrate-subxt's git commit in Cargo.lock should be updated to wuminzhe/substrate-subxt@c9163be

fixed by 486fd64

@hackfisher hackfisher merged commit 3e7760c into master Apr 19, 2021
@hackfisher hackfisher deleted the token-bridge branch April 19, 2021 07:04
}
s
}};
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These format looks weird

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants