Skip to content

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2023
Merged

fix: possible assert call if nHeight in CDeterministicMNList is higher then Tip #5590

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d513c1f
fix: possible assert call if nHeight in CDeterministicMNListDiff is h…
knst Sep 28, 2023
ca61600
fix: use g_chainman.m_blockman.LookupBlockIndex for any known block (…
knst Sep 28, 2023
8e63c16
fix: handle GetProjectedMNPayees's failures in `MasternodeList::updat…
UdjinM6 Oct 21, 2023
2ca24de
fix: resulting vector in GetProjectedMNPayees grows to the weighted c…
UdjinM6 Oct 21, 2023
660a5ca
fix: avoid useless loop in GetProjectedMNPayees after mn_rr activation
UdjinM6 Oct 21, 2023
e258c36
fix: pass proper CBlockIndex from ClientModel
knst Oct 26, 2023
41560f0
fix statusItem
UdjinM6 Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use g_chainman.m_blockman.LookupBlockIndex for any known block (… 
…even wrong tip)
  • Loading branch information
@knst
knst committed Oct 26, 2023
commit ca61600719638ae4ea55ff8f2327bfca658e65ca
4 changes: 2 additions & 2 deletions src/evo/deterministicmns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,9 @@ CDeterministicMNCPtr CDeterministicMNList::GetMNPayee(const CBlockIndex* pIndex)

std::vector<CDeterministicMNCPtr> CDeterministicMNList::GetProjectedMNPayeesAtChainTip(int nCount) const
{
const CBlockIndex* const pindex = ::ChainActive()[nHeight];
const CBlockIndex* const pindex = WITH_LOCK(::cs_main, return g_chainman.m_blockman.LookupBlockIndex(blockHash));
if (pindex == nullptr) {
LogPrintf("GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr due to height=%lld chain height=%lld\n", nHeight, ::ChainActive().Tip()->nHeight);
LogPrintf("GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr on height=%lld blockhash=%s tip height=%lld tip hash=%s\n", nHeight, blockHash.ToString(), ::ChainActive().Tip()->nHeight, ::ChainActive().Tip()->GetBlockHash().ToString());
return {};
}
return GetProjectedMNPayees(pindex, nCount);
Expand Down