Skip to content

fix: Start LLMQContext early to let VerifyDB() check ChainLock signatures in coinbase #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: Start LLMQContext early to let VerifyDB() check ChainLock signatures in coinbase #5752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde2f6b
fix: Start LLMQContext early to let `VerifyDB()` check ChainLock sign…
UdjinM6 Dec 4, 2023
d8d1be9
fix: need to call Interrupt() first
UdjinM6 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,8 +1930,15 @@ bool AppInitMain(const CoreContext& context, NodeContext& node, interfaces::Bloc
creditPoolManager.reset(new CCreditPoolManager(*node.evodb));
llmq::quorumSnapshotManager.reset();
llmq::quorumSnapshotManager.reset(new llmq::CQuorumSnapshotManager(*node.evodb));

if (node.llmq_ctx) {
node.llmq_ctx->Interrupt();
node.llmq_ctx->Stop();
}
node.llmq_ctx.reset();
node.llmq_ctx.reset(new LLMQContext(chainman.ActiveChainstate(), *node.connman, *node.evodb, *::sporkManager, *node.mempool, node.peerman, false, fReset || fReindexChainState));
// Have to start it early to let VerifyDB check ChainLock signatures in coinbase
node.llmq_ctx->Start();

if (fReset) {
pblocktree->WriteReindexing(true);
Expand Down Expand Up @@ -2298,8 +2305,6 @@ bool AppInitMain(const CoreContext& context, NodeContext& node, interfaces::Bloc
node.scheduler->scheduleEvery(std::bind(&PeriodicStats, std::ref(*node.args), std::cref(*node.mempool)), std::chrono::seconds{nStatsPeriod});
}

node.llmq_ctx->Start();

// ********************************************************* Step 11: import blocks

if (!CheckDiskSpace(GetDataDir())) {
Expand Down