Skip to content

feat: make PrivateKey#toBuffer method return padded buffer #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shumkov merged 2 commits into from
Apr 18, 2023
Merged

feat: make PrivateKey#toBuffer method return padded buffer #278

shumkov merged 2 commits into from
Apr 18, 2023

Conversation

@jawid-h
Copy link
Collaborator

@jawid-h jawid-h commented Apr 17, 2023 •
edited
Loading

Issue being fixed or feature implemented

Making PrivateKey#toBuffer method return padded buffer

What was done?

  • updated bn.toBuffer call

How Has This Been Tested?

  • unit tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@jawid-h jawid-h requested review from antouhou and markin-io April 17, 2023 12:32
shumkov
shumkov approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 49c036a into master Apr 18, 2023
@shumkov shumkov deleted the feat/priv-key-to-buf-opts branch April 18, 2023 10:38
@Mhmonicox Mhmonicox mentioned this pull request May 25, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shumkov shumkov shumkov approved these changes

@markin-io markin-io Awaiting requested review from markin-io

+1 more reviewer

@antouhou antouhou antouhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jawid-h @shumkov @antouhou